- When background syncing, the wallet wipes the spend key
from memory and processes all new transactions. The wallet saves
all receives, spends, and "plausible" spends of receives the
wallet does not know key images for.
- When background sync disabled, the wallet processes all
background synced txs and then clears the background sync cache.
- Adding "plausible" spends to the background sync cache ensures
that the wallet does not need to query the daemon to see if any
received outputs were spent while background sync was enabled.
This would harm privacy especially for users of 3rd party daemons.
- To enable the feature in the CLI wallet, the user can set
background-sync to reuse-wallet-password or
custom-background-password and the wallet automatically syncs in
the background when the wallet locks, then processes all
background synced txs when the wallet is unlocked.
- The custom-background-password option enables the user to
open a distinct background wallet that only has a view key saved
and can be opened/closed/synced separately from the main wallet.
When the main wallet opens, it processes the background wallet's
cache.
- To enable the feature in the RPC wallet, there is a new
`/setup_background_sync` endpoint.
- HW, multsig and view-only wallets cannot background sync.
1. new wallet "set" parameter "send-change-back-to-subaddress [1|0]"
The change for a transaction can now be sent back to the main address for the wallet (default)
or to the sending subaddress
(* please note that for AUDIT TX type, it will ALWAYS be sent back to the subaddress)
2. fixed erroneous code setting "source_asset" in wallet2::process_new_transaction()
This bug caused change entries to appear in all TXs when querying using "get_transfer_by_txid"
RPC method as "in" output types. Whilst this is fully conformant to the Monero Docs that
describe the method in question, it did not conform to the experience of the RPC method users
or to traditional Monero RPC output.
fixed#20 : Audit transaction is showing in yield_info, but says 0 yield
fixed#19 : if you send SAL1, while the tx is pending it shows in the sal balance
fixed#18 : yield_info display is showing the wrong unlock time (TESTNET)
fixed#17 : SAL appears to be accrued during audit
1. rewrite of the Haven variation of the Pricing Record class to support:
- versioning of the PR format
- nested supply_data and asset_data structs
- verification of the signature using a variable-length string (not R+S)
2. calculation of the slippage tallies for a block in add_block(), so that
we can work out the yield that is due to be paid out for the block.
Loads of little fixes and cleanups.
jeffro256