carrot_impl: propogate exceptions in scan_key_image instead of swallowing them

2025-04-24 13:00:43 -05:00
parent ec46d14fe5
commit c72543bb63
1 changed files with 3 additions and 2 deletions
@@ -3249,8 +3249,9 @@ void wallet2::process_parsed_blocks(const uint64_t start_height, const std::vect
      tx_output_idx += tx.vout.size();
    }
  }
-  if (!scan_blocks_waiter.wait())
-    MERROR("Failed to scan block's tx outputs, the wallet may miss owned enotes");
+  THROW_WALLET_EXCEPTION_IF(!scan_blocks_waiter.wait(),
+    error::wallet_internal_error,
+    "Exception in enote / key image scanning threadpool");

  size_t current_index = start_height;
  tx_output_idx = 0;