check accessing an element past the end of a container

2017-12-12 11:08:11 +00:00
parent 2305bf260d
commit b49ddc766d
8 changed files with 46 additions and 12 deletions
@@ -190,6 +190,12 @@ namespace cryptonote
  //---------------------------------------------------------------
  bool construct_tx_with_tx_key(const account_keys& sender_account_keys, const std::unordered_map<crypto::public_key, subaddress_index>& subaddresses, std::vector<tx_source_entry>& sources, const std::vector<tx_destination_entry>& destinations, const boost::optional<cryptonote::account_public_address>& change_addr, std::vector<uint8_t> extra, transaction& tx, uint64_t unlock_time, const crypto::secret_key &tx_key, const std::vector<crypto::secret_key> &additional_tx_keys, bool rct, bool bulletproof, rct::multisig_out *msout)
  {
+    if (sources.empty())
+    {
+      LOG_ERROR("Empty sources");
+      return false;
+    }
+
    std::vector<rct::key> amount_keys;
    tx.set_null();
    amount_keys.clear();