remove tools::add_element

src/wallet/scanning_tools.cpp

@@ -36,7 +36,6 @@
 #include "carrot_core/lazy_amount_commitment.h"
 #include "carrot_core/scan.h"
 #include "carrot_impl/format_utils.h"
-#include "common/container_helpers.h"
 #include "crypto/generators.h"
 #include "cryptonote_basic/cryptonote_format_utils.h"
 #include "ringct/rctOps.h"
@@ -487,14 +486,14 @@ void perform_ecdh_derivations(const epee::span<const crypto::public_key> main_tx
         {
             hwdev.generate_key_derivation(main_tx_ephemeral_pubkey,
                 k_view_incoming,
-                tools::add_element(main_derivations_out));
+                main_derivations_out.emplace_back());
         }
 
         for (const crypto::public_key &additional_tx_ephemeral_pubkey : additional_tx_ephemeral_pubkeys)
         {
             hwdev.generate_key_derivation(additional_tx_ephemeral_pubkey,
                 k_view_incoming,
-                tools::add_element(additional_derivations_out));
+                additional_derivations_out.emplace_back());
         }
     }
 }

src/wallet/wallet2.cpp

@@ -2621,7 +2621,7 @@ void wallet2::process_new_scanned_transaction(
         continue;
 
     // update m_transfers view-incoming scan info, and default values
-    transfer_details& td = tools::add_element(m_transfers);
+    transfer_details& td = m_transfers.emplace_back();
     td.m_block_height = height;
     td.m_internal_output_index = local_output_index;
     td.m_global_output_index = o_indices.at(local_output_index);